Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Minor changes too schema property descriptions #1577

Merged
merged 4 commits into from
Jul 1, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Jun 27, 2020

Pull Request (PR) description

  • SqlServerDsc
    • Minor changes too schema property descriptions to generate documentation
      correctly.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #1577 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1577   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          37      37           
  Lines        6074    6074           
======================================
  Hits         5970    5970           
  Misses        104     104           

@johlju johlju added the needs review The pull request needs a code review. label Jun 28, 2020
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 13 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 79080ca into dsccommunity:master Jul 1, 2020
@johlju johlju deleted the fix/docs branch July 1, 2020 19:09
@johlju johlju removed the needs review The pull request needs a code review. label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant