SqlServerDsc: Documentation updates #1576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
.github/CONTRIBUTION.md
as it no longer filled anypurpose as GitHub will find the CONTRIBUTION.md in the root folder
directly now (issue Move the CONTRIBUTING.md files together #1227).
use passwords (issue SqlSetup: Does not allow null or empty password for MSA #378)
and (issue SqlSetup: Add documentation around how to use built-in account #1230).
integration tests for SqlSetup, SqlRSSetup, and SqlRS does (issue Integration Tests: Contributing.md should be updated with the different test jobs #1315).
(issue SqlAGReplica: InnerException: Invalid column name 'required_copies_to_commit' #1033).
either the
Edition
orProductKey
that could be misleading (issue SqlRSSetup: Document that the properties ProductKey and Edition is mutually exclusive #1386).Edition
andProductKey
that they are mutually exclusive (issue SqlRSSetup: Document that the properties ProductKey and Edition is mutually exclusive #1386).This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is