Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: SqlSetup: Fix AgtSvcStartupType to not default to Automatic #1529

Merged
merged 4 commits into from
May 7, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented May 6, 2020

Pull Request (PR) description

  • SqlSetup
    • BREAKING CHANGE: Now if the parameter AgtSvcStartupType is not specified
      in the configuration the resource will no longer by default add an
      argument to setup.exe with a value of Automatic for the argument
      AGTSVCSTARTUPTYPE. If the parameter AgtSvcStartupType is not specified
      in the configuration there will be no setup argument added at all
      (issue SqlSetup: Agent service is hard coded to start automatically #464).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. needs review The pull request needs a code review. labels May 6, 2020
@johlju johlju changed the title SqlSetup: Fix AgtSvcStartupType to not default to Automatic BREAKING CHANGE: SqlSetup: Fix AgtSvcStartupType to not default to Automatic May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #1529 into master will increase coverage by 0%.
The diff coverage is 44%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1529   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          39      39           
  Lines        5942    5923   -19     
======================================
- Hits         5832    5814   -18     
+ Misses        110     109    -1     

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit aa5cb80 into dsccommunity:master May 7, 2020
@johlju johlju deleted the fix/issue-464 branch May 7, 2020 18:21
@johlju johlju removed the needs review The pull request needs a code review. label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlSetup: Agent service is hard coded to start automatically
1 participant