Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Update CHANGELOG with the historic changelog #1525

Merged
merged 2 commits into from
May 6, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented May 3, 2020

Pull Request (PR) description

  • Update CHANGELOG with the historic changelog

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label May 3, 2020
@johlju johlju force-pushed the fix/update-historic-changelog branch from 7596aca to 8fbc00a Compare May 3, 2020 14:12
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #1525 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1525   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          39      39           
  Lines        5921    5921           
======================================
  Hits         5826    5826           
  Misses         95      95           

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit e6cb820 into dsccommunity:master May 6, 2020
@johlju johlju deleted the fix/update-historic-changelog branch May 6, 2020 04:49
@johlju johlju removed the needs review The pull request needs a code review. label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: No longer a need for the historic changelog
1 participant