Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: SqlServerDsc: Remove SqlServerNetwork #1518

Merged
merged 3 commits into from
May 5, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented May 3, 2020

Pull Request (PR) description

  • SqlServerDsc
    • BREAKING CHANGE: Removed resource SqlServerNetwork. The functionality
      is now covered by the resources SqlServerProtocol and SqlServerProtocolTcpIp.

Dependent on the PR #1511 and PR #1517.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added needs review The pull request needs a code review. breaking change When used on an issue, the issue has been determined to be a breaking change. labels May 3, 2020
@johlju johlju force-pushed the f/remove-SqlServerNetworking branch from 21b02f5 to b29bd5a Compare May 5, 2020 09:09
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #1518 into master will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1518    +/-   ##
=======================================
  Coverage      98%     98%            
=======================================
  Files          40      39     -1     
  Lines        6027    5921   -106     
=======================================
- Hits         5930    5826   -104     
+ Misses         97      95     -2     

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit bd0f92c into dsccommunity:master May 5, 2020
@johlju johlju deleted the f/remove-SqlServerNetworking branch May 5, 2020 13:48
@johlju johlju removed the needs review The pull request needs a code review. label May 5, 2020
@johlju johlju restored the f/remove-SqlServerNetworking branch May 10, 2020 15:57
johlju added a commit that referenced this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change.
Projects
None yet
1 participant