Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Fix hashtables to align with style guideline #1440

Closed
wants to merge 0 commits into from

Conversation

johlju
Copy link
Member

@johlju johlju commented Oct 29, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Oct 29, 2019
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1440 into dev will decrease coverage by <1%.
The diff coverage is 98%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1440   +/-   ##
====================================
- Coverage    98%     98%   -1%     
====================================
  Files        38      38           
  Lines      5603    5626   +23     
====================================
+ Hits       5497    5519   +22     
- Misses      106     107    +1

@johlju johlju force-pushed the fix-hashtables branch 3 times, most recently from 1c5d0ee to ec998a1 Compare November 9, 2019 12:24
@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Nov 9, 2019
@johlju johlju closed this Nov 30, 2019
@johlju johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Resolve style guideline violations for hashtables
2 participants