SqlServerDsc: Consequently use parameters ServerName and InstanceName

[johlju]

Pull Request (PR) description

• Changes to SqlServerDsc
  • Changes to helper function Invoke-Query
    • Parameters now match that of Connect-SQL (issue SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392).
  • Changes to helper function Connect-SQLAnalysis
    • Parameters now match that of Connect-SQL (issue SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392).
  • Changes to helper function Restart-SqlService
    • Parameters now match that of Connect-SQL (issue SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392).
  • Changes to helper function Restart-ReportingServicesService
    • Parameters now match that of Connect-SQL (issue SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392).
  • Changes to helper function Split-FullSqlInstanceName
    • Parameters and function name changed to use correct casing.
  • Changes to helper function Get-SqlInstanceMajorVersion
    • Parameters now match that of Connect-SQL (issue SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392).
  • Changes to helper function Test-LoginEffectivePermissions
    • Parameters now match that of Connect-SQL (issue SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392).
  • Changes to helper function Test-AvailabilityReplicaSeedingModeAutomatic
    • Parameters now match that of Connect-SQL (issue SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392).

This will clean up the last on the old parameter names. Having been looking at doing this for a long time :)

This Pull Request (PR) fixes the following issues

• Fixes SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #1409 into dev will decrease coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #1409   +/-   ##
====================================
- Coverage    98%     98%   -1%     
====================================
  Files        37      37           
  Lines      5540    5538    -2     
====================================
- Hits       5434    5432    -2     
  Misses      106     106

[johlju]

Reviewed 12 of 12 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved