Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlWindowsFirewall: Added localization #1336

Merged
merged 4 commits into from
Apr 26, 2019
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 25, 2019

Pull Request (PR) description

  • Changes to SqlSetup
    • Made the error message more descriptive when the Set-TargetResource
      function calls the Test-TargetResource function to verify the desired
      state.
  • Changes to SqlWindowsFirewall
  • Changes to SqlRS
    • Fixed one of the error handling to use localization, and made the
      error message more descriptive when the Set-TargetResource function
      calls the Test-TargetResource function to verify the desired
      state. This was done prior to adding full en-US localization.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Apr 25, 2019
@codecov-io
Copy link

codecov-io commented Apr 25, 2019

Codecov Report

Merging #1336 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##            dev   #1336    +/-   ##
=====================================
+ Coverage    98%     98%   +<1%     
=====================================
  Files        36      36            
  Lines      4986    5013    +27     
=====================================
+ Hits       4917    4944    +27     
  Misses       69      69

johlju added 4 commits April 26, 2019 13:55
  - Added en-US localization (issue dsccommunity#614).
- Made the error message more descriptive when the Set-TargetResource
  function calls the Test-TargetResource function to verify the desired
  state.
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 874c8aa into dsccommunity:dev Apr 26, 2019
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Apr 26, 2019
@johlju johlju deleted the fix-issue-614 branch April 27, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlWindowsFirewall: Localization should change to align with HQRM modules
3 participants