Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerLogin: Error is thrown when SqlLogin is run in Integrated mode #1266

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 11, 2019

Pull Request (PR) description

  • Changes to SqlServerLogin
    • Now when adding a login of type SqlLogin, and the SQL Server login mode
      is set to 'Integrated', an error is correctly thrown
      (issue #1179).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jan 11, 2019
@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #1266 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1266   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        34      34           
  Lines      4197    4197           
====================================
  Hits       4106    4106           
  Misses       91      91

@johlju johlju changed the title SqlServerLogin: Error is thrown when SqlLogin is un in Integrated mode SqlServerLogin: Error is thrown when SqlLogin is run in Integrated mode Jan 21, 2019
- Now when adding a login of type SqlLogin, and the SQL Server login mode
  is set to `'Integrated'`, an error is correctly thrown (issue dsccommunity#1179).
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 08ded66 into dsccommunity:dev Jan 21, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Jan 25, 2019
@johlju johlju deleted the fix-issue-1179 branch February 4, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerLogin: When LoginMode is 'Integrated' there is no error thrown
2 participants