Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc: Fixes integration test fail to install default instance #1262

Merged
merged 4 commits into from
Dec 31, 2018
Merged

SqlServerDsc: Fixes integration test fail to install default instance #1262

merged 4 commits into from
Dec 31, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 31, 2018 •
edited by joeyaiello
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju
Changes to SqlServerDsc
62a1f60 
- During testing in AppVeyor the Build Worker is restarted in the install
  step to make sure the are no residual changes left from a previous SQL
  Server install on the Build Worker done by the AppVeyor Team (issue dsccommunity#1260).
@johlju johlju added the needs review The pull request needs a code review. label Dec 31, 2018
@johlju
Copy link
Member Author

johlju commented Dec 31, 2018

Closing and reopening to kick off the tests again since they seemed to hang.

@johlju johlju closed this Dec 31, 2018
@johlju johlju reopened this Dec 31, 2018
@codecov-io
Copy link

Codecov Report

Merging #1262 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1262   +/-   ##
====================================
  Coverage    98%     98%           
====================================
  Files        34      34           
  Lines      4171    4171           
====================================
  Hits       4113    4113           
  Misses       58      58

@johlju
Copy link
Member Author

johlju commented Dec 31, 2018

Closing this or and reopen to kick off the tests yet again

@johlju johlju closed this Dec 31, 2018
@johlju johlju reopened this Dec 31, 2018
johlju
johlju commented Dec 31, 2018
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit e57f994 into dsccommunity:dev Dec 31, 2018
@johlju johlju deleted the debug-tests branch December 31, 2018 21:58
@johlju johlju removed the needs review The pull request needs a code review. label Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Integration tests fail to install instance
2 participants
@johlju @codecov-io