Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAlwaysOnService: Updated integration tests to use NetworkingDsc #1229

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 21, 2018

Pull Request (PR) description

  • Changes to SqlAlwaysOnService
    • Updated integration tests to use NetworkingDsc
      (issue #1129).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #1229 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1229   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        34      34           
  Lines      4171    4171           
====================================
  Hits       4083    4083           
  Misses       88      88

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Sep 21, 2018
- Updated integration tests to use NetworkingDsc (issue dsccommunity#1129).
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Sep 27, 2018
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 62227f3 into dsccommunity:dev Sep 27, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Sep 27, 2018
@johlju johlju deleted the fix-networkingdsc branch September 27, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlAlwaysOnService: Integration tests should use NetworkingDsc once released
2 participants