-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerMemory: Fix so auto memory on Azure VMs is reported correctly #1154
Conversation
Updated Cim Class to Win32_ComputerSystem (instead of Win32_PhysicalMemory) because the correct memory size was not being detected correctly on Azure VMs #914
Fixed missing paren :(
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
======================================
- Coverage 97% 97% -1%
======================================
Files 33 33
Lines 4005 4005
======================================
- Hits 3916 3898 -18
- Misses 89 107 +18 |
@ejleroy Many thanks for your contribution and fixing this issue! Reviewed 1 of 1 files at r1. a discussion (no related file): a discussion (no related file):
Comments from Reviewable |
@ejleroy FYI. This particular problem in the tests is not caused by this PR 🤔 I will open a new issue for this. |
@johlju Added the below changes to the CHANGELOG.md in unreleased section
|
For me to be able to merge this change, then please
There are merge conflicts since your PR was not based on the latest changes. Could you please rebase against branch dev using |
Updated Cim Class to Win32_ComputerSystem (instead of Win32_PhysicalMemory) because the correct memory size was not being detected correctly on Azure VMs #914
Fixed missing paren :(
@johlju Rebased and recommitted the fix. Test just kicked off and waiting for success. |
Please resolve the failing tests here https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.373.0?fullLog=true#L4510 and here https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.373.0?fullLog=true#L1684 |
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
Closing this PR as it has been opened a new PR. |
Updated Cim Class to Win32_ComputerSystem (instead of Win32_PhysicalMemory) because the correct memory size was not being detected correctly on Azure VMs
Fixes #914
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
should say what was changed, and how that affects users (if applicable).
and comment-based help?
See DSC Resource Testing Guidelines.
See DSC Resource Testing Guidelines.
DSC Resource Style Guidelines
and Best Practices?
This change is