Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerMemory: Fix so auto memory on Azure VMs is reported correctly #1154

Closed
wants to merge 7 commits into from

Conversation

ejleroy
Copy link
Contributor

@ejleroy ejleroy commented Jun 27, 2018

Updated Cim Class to Win32_ComputerSystem (instead of Win32_PhysicalMemory) because the correct memory size was not being detected correctly on Azure VMs

Fixes #914

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md? Entry
    should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md?
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help?
  • Comment-based help added/updated?
  • Localization strings added/updated in all localization files as appropriate?
  • Examples appropriately added/updated?
  • Unit tests added/updated?
    See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible)?
    See DSC Resource Testing Guidelines.
  • New/changed code adheres to
    DSC Resource Style Guidelines
    and Best Practices?

This change is Reviewable

ejleroy added 2 commits June 27, 2018 15:36
Updated Cim Class to Win32_ComputerSystem (instead of Win32_PhysicalMemory) because the correct memory size was not being detected correctly on Azure VMs
#914
Fixed missing paren :(
@ejleroy ejleroy closed this Jun 27, 2018
@ejleroy ejleroy reopened this Jun 27, 2018
@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #1154 into master will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1154   +/-   ##
======================================
- Coverage      97%     97%   -1%     
======================================
  Files          33      33           
  Lines        4005    4005           
======================================
- Hits         3916    3898   -18     
- Misses         89     107   +18

@johlju
Copy link
Member

johlju commented Jun 28, 2018

@ejleroy Many thanks for your contribution and fixing this issue!


Reviewed 1 of 1 files at r1.
Review status: all files reviewed, 2 unresolved discussions (waiting on @ejleroy)


a discussion (no related file):
The tests are failing could you please look at resolving those? I can't merge until the tests are passing. Thanks!
https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.369.0?fullLog=true#L4470


a discussion (no related file):
Could you please add an descriptive entry, for each change/issue, to the Unreleased section of the change log in the file README.md? If an entry resolves an issue please reference the issue where applicable. You may suffix (it's optional) each entry with your name. Example of the format for the entry.

* Descriptive entry ([issue #123](https://github.com/PowerShell/xPSDesiredStateConfiguration/issues/123). [Name/Alias (@github_account)](https://github.com/github_account)

Comments from Reviewable

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jun 28, 2018
@johlju johlju changed the title Update MSFT_SqlServerMemory.psm1 SqlServerMemory: Fix so auto memory on Azure VMs is reported correctly Jun 28, 2018
@johlju
Copy link
Member

johlju commented Jun 28, 2018

@ejleroy FYI. This particular problem in the tests is not caused by this PR 🤔 I will open a new issue for this.
https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.369.0?fullLog=true#L7771

@msftclas
Copy link

msftclas commented Jul 1, 2018

CLA assistant check
All CLA requirements met.

@ejleroy
Copy link
Contributor Author

ejleroy commented Jul 1, 2018

@johlju Added the below changes to the CHANGELOG.md in unreleased section

  • Changes to SqlServerMemory
    • Using Get-CimInstance -ClassName Win32_ComputerSystem).TotalPhysicalMemory
      (issue #1154)

@johlju johlju added waiting for CLA pass and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jul 1, 2018
@johlju
Copy link
Member

johlju commented Jul 1, 2018

For me to be able to merge this change, then please

There are merge conflicts since your PR was not based on the latest changes. Could you please rebase against branch dev using git rebase (not by using git pull or git merge, to keep the commit history). If you don't know how to rebase your local dev and working branch, please look at how to Resolve merge conflicts.
Let me know if you need any assistance.

ejleroy added 4 commits July 2, 2018 18:46
Updated Cim Class to Win32_ComputerSystem (instead of Win32_PhysicalMemory) because the correct memory size was not being detected correctly on Azure VMs
#914
Fixed missing paren :(
@ejleroy
Copy link
Contributor Author

ejleroy commented Jul 2, 2018

@johlju Rebased and recommitted the fix. Test just kicked off and waiting for success.

@johlju johlju added needs review The pull request needs a code review. and removed waiting for CLA pass labels Jul 3, 2018
@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Jul 3, 2018
@stale
Copy link

stale bot commented Jul 17, 2018

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@johlju
Copy link
Member

johlju commented Feb 20, 2019

Closing this PR as it has been opened a new PR.

@johlju johlju closed this Feb 20, 2019
@johlju johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerMemory: Auto memory on Azure VMs is off by an order of magnitude on large VMs
4 participants