Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helper function for generating stubs file (fixes #111) #112

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 17, 2016

This change is Reviewable

@msftclas
Copy link

Hi @johlju, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@kwirkykat kwirkykat added the needs review The pull request needs a code review. label Aug 19, 2016
@mbreakey3
Copy link
Contributor

Awesome, so this creates an identical stubs file as the one that is included in the module that you created?

@johlju
Copy link
Member Author

johlju commented Aug 19, 2016

Yes, I used this function to create the stub files.
But it does not generate the comment at the top, see below. I added that manually. If you think it should, I might be able to get the information from the system somehow. But it was easy enough to add that manually. What do you think?

# Generated from SQL Server 2014 (build 12.0.4213.0)

@mbreakey3
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@mbreakey3 mbreakey3 merged commit d906654 into dsccommunity:dev Aug 19, 2016
@vors vors removed the needs review The pull request needs a code review. label Aug 19, 2016
@johlju johlju deleted the adding-stub-generator branch August 20, 2016 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants