Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove this resource #990

Closed
johlju opened this issue Jan 1, 2018 · 1 comment · Fixed by #991
Closed

BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove this resource #990

johlju opened this issue Jan 1, 2018 · 1 comment · Fixed by #991
Assignees
@johlju
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jan 1, 2018 •
edited
Loading

Details of the scenario you tried and the problem that is occurring:
I suggest we move SecureConnectionLevel parameter to the SqlRS resource and remove SqlRSSecureConnectionLevel.

This was initially suggested in issue #587, but that issue is more to add SSL functionality. We could start by adding the parameter SecureConnectionLevel to the SqlRS resource. This would improve the SqlRS resource, and remove a lot of technical debt.

The resource SqlRSSecureConnectionLevel only changes value of property SecureConnectionLevel, so it's a bit unnecessary for it to be a separate resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju changed the title SqlServerRSSecureConnectionLevel: Deprecate this resource BREAKING CHANGE: SqlServerRSSecureConnectionLevel: Deprecate this resource Jan 1, 2018
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Jan 1, 2018
@johlju johlju changed the title BREAKING CHANGE: SqlServerRSSecureConnectionLevel: Deprecate this resource BREAKING CHANGE: SqlRSSecureConnectionLevel: Deprecate this resource Jan 1, 2018
@johlju johlju changed the title BREAKING CHANGE: SqlRSSecureConnectionLevel: Deprecate this resource BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove this resource Jan 1, 2018
@johlju johlju mentioned this issue Jan 1, 2018
Open
@johlju
Copy link
Member Author

johlju commented Jan 1, 2018

I wrongly wrote deprecate when I meant remove. I updated the issue title, and also added breaking change label.

@johlju johlju mentioned this issue Jan 1, 2018
Merged
5 tasks
johlju added a commit that referenced this issue Jan 4, 2018
@johlju
BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove resource in favor…
888c069 
… of SqlRS (#991)

- Changes to SqlServerDsc
  - BREAKING CHANGE: Resource SqlRSSecureConnectionLevel was remove (issue #990).
    The parameter that was set using that resource has been merged into resource
    SqlRS as the parameter UseSsl. The UseSsl parameter is of type boolean. This
    change was made because from SQL Server 2008 R2 this value is made an on/off
    switch. Read more in the article [ConfigurationSetting Method - SetSecureConnectionLevel](https://docs.microsoft.com/en-us/sql/reporting-services/wmi-provider-library-reference/configurationsetting-method-setsecureconnectionlevel).
- Changes to SqlRS
  - Added parameter UseSsl which when set to $true forces connections to the
    Reporting Services to use SSL when connecting (issue #990).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove resource in favor of SqlRS johlju/SqlServerDsc
1 participant
@johlju