Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlSetup: Example referencing fixed issue #975

Closed
johlju opened this issue Dec 29, 2017 · 0 comments · Fixed by #1609
Closed

SqlSetup: Example referencing fixed issue #975

johlju opened this issue Dec 29, 2017 · 0 comments · Fixed by #1609
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Dec 29, 2017

Details of the scenario you tried and the problem that is occurring:
The example 4-InstallNamedInstanceInFailoverClusterFirstNode.ps1 is referencing issue #444 which has been fixed. This example should be updated to remove the text referencing the bug.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added easy fix enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Dec 29, 2017
@johlju johlju removed the easy fix label Apr 29, 2018
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 11, 2020
@johlju johlju mentioned this issue Aug 11, 2020
Merged
9 tasks
johlju added a commit that referenced this issue Aug 11, 2020
@johlju
SqlSetup: Update comment-based help in example (#1609)
9684eab 
- SqlSetup
  - The example 4-InstallNamedInstanceInFailoverClusterFirstNode.ps1 was
    updated to no longer reference the issue #405 and issue #444 in the
    comment-based help. The issues was fixed a while back and SqlSetup
    now supports the built-in parameter PsDscRunAsCredential (issue #975).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlSetup: Update comment-based help in example johlju/SqlServerDsc
1 participant
@johlju