Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlDatabasePermission: Integration test is missing for this resource #741

Closed
johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #1556
Closed

SqlDatabasePermission: Integration test is missing for this resource #741

johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #1556
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Aug 13, 2017

Details of the scenario you tried and the problem that is occurring:
We should add an integration test for this resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Aug 13, 2017
@johlju johlju changed the title xSQLServerDatabasePermission: Integration test is missing for this resource SqlDatabasePermission: Integration test is missing for this resource Dec 23, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 23, 2020
@johlju johlju mentioned this issue May 23, 2020
Merged
9 tasks
johlju added a commit that referenced this issue May 25, 2020
@johlju
BREAKING CHANGE: SqlDatabasePermission: Remove create user (#1556)
e711c4a 
- SqlDatabasePermission
  - BREAKING CHANGE: The resource no longer create the database user if
    it does not exist. Use the resource _SqlDatabaseUser_ to enforce that
    the database user exist in the database prior to setting permissions
    using this resource (issue #848).
  - BREAKING CHANGE: The resource no longer checks if a login exist so that
    it is possible to set permissions for database users that does not
    have a login, e.g. the database user 'guest' (issue #1134).
  - Updated examples.
  - Added integration tests (issue #741).
  - Get-TargetResource will no longer throw an exception if the database
    does not exist.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlDatabasePermission: Remove create user johlju/SqlServerDsc
1 participant
@johlju