Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLAOGroupEnsure doesn't handle the SetupCredential correctly #58

Closed
Matticusau opened this issue May 12, 2016 · 0 comments
Closed

xSQLAOGroupEnsure doesn't handle the SetupCredential correctly #58

Matticusau opened this issue May 12, 2016 · 0 comments
Labels
bug The issue is a bug.

Comments

@Matticusau
Copy link
Contributor

While building the pester test for xSQLAOGroupEnsure resource I have found that there are inconsistencies in how it handles the SetupCredential parameter across the functions.

The following are the inconsistencies I have found:

  1. On all three *-TargetResource functions the SetupCredential parameter is mandatory but not always used.
  2. In Set-TargetResouce the parameter SetupCredential is mandatory and passed to Connect-SQL but if the user wants to use Windows Auth then they shouldn't have to pass this credential (or at least set it to $null which would allow Connect-SQL to use it correctly)
  3. In Get-TargetResource the parameter SetupCredential is mandatory but not used. It should be optional and passed to the Connect-SQL and Test-TargetResource functions appropriately
  4. In Test-TargetResource the parameter SetupCredential is mandatory but not used. It should be optional and passed to the Connect-SQL
Matticusau added a commit to Matticusau/xSQLServer that referenced this issue May 12, 2016
@Matticusau
Fixes dsccommunity#58 and adds test coverage for xSQLAOGroupEnsure
80a017c
@Matticusau Matticusau mentioned this issue May 12, 2016
Closed
@kwirkykat kwirkykat added the bug The issue is a bug. label Aug 2, 2016
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 21, 2016
@johlju
Aligned schemas with README.md
d37ab0b 
Also added add text that explains the use of the credential parameter (issue from dsccommunity#58)
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 22, 2016
@johlju
Aligned schemas with README.md
4e88d03 
Also added add text that explains the use of the credential parameter (issue from dsccommunity#58)
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 11, 2016
@johlju
Aligned schemas with README.md
1a51514 
Also added add text that explains the use of the credential parameter (issue from dsccommunity#58)
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 11, 2016
@johlju
Changes to xSQLAlias
e235fe2 
Fixed a bug if the alias did not exists then Get-ItemProperty would throw an error.
Fixed a bug so that the logic to create a new alias is triggered. If the alias did not exist it was the change-logic that created the alias, not the create-logic.
Fixed a bug in the create-logic that throw an error if the key ConnectTo already existed. Removed that New-Item since we already test for the existence of the key.
Also some style changes.

Changes to xSQLAlias
Improved testing and added a test for removal of alias
Bug found with the test, create-logic was called when it shouldn't

Aligned schemas with README.md
Also added add text that explains the use of the credential parameter (issue from dsccommunity#58)
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 11, 2016
@johlju
Changes to xSQLAlias
61dbaee 
Fixed a bug if the alias did not exists then Get-ItemProperty would throw an error.
Fixed a bug so that the logic to create a new alias is triggered. If the alias did not exist it was the change-logic that created the alias, not the create-logic.
Fixed a bug in the create-logic that throw an error if the key ConnectTo already existed. Removed that New-Item since we already test for the existence of the key.
Also some style changes.

Changes to xSQLAlias
Improved testing and added a test for removal of alias
Bug found with the test, create-logic was called when it shouldn't

Aligned schemas with README.md
Also added add text that explains the use of the credential parameter (issue from dsccommunity#58)
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 11, 2016
@johlju
Improvements to xSQLAlias resource and the tests
dd52630 
Fixed a bug if the alias did not exists then Get-ItemProperty would throw an error.
Fixed a bug so that the logic to create a new alias is triggered. If the alias did not exist it was the change-logic that created the alias, not the create-logic.
Fixed a bug in the create-logic that throw an error if the key ConnectTo already existed. Removed that New-Item since we already test for the existence of the key.
Also some style changes.

Changes to xSQLAlias
Improved testing and added a test for removal of alias
Bug found with the test, create-logic was called when it shouldn't

Aligned schemas with README.md
Also added add text that explains the use of the credential parameter (issue from dsccommunity#58)
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 17, 2016
@johlju
Improvements to xSQLAlias resource and the tests
f1e3512 
Fixed a bug if the alias did not exists then Get-ItemProperty would throw an error.
Fixed a bug so that the logic to create a new alias is triggered. If the alias did not exist it was the change-logic that created the alias, not the create-logic.
Fixed a bug in the create-logic that throw an error if the key ConnectTo already existed. Removed that New-Item since we already test for the existence of the key.
Also some style changes.

Changes to xSQLAlias
Improved testing and added a test for removal of alias
Bug found with the test, create-logic was called when it shouldn't

Aligned schemas with README.md
Also added add text that explains the use of the credential parameter (issue from dsccommunity#58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwirkykat @Matticusau