Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerSetup: Helper function Connect-SQLAnalysis does not have correct error handling #436

Closed
johlju opened this issue Mar 11, 2017 · 0 comments · Fixed by #438
Closed
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Mar 11, 2017

Details of the scenario you try and problem that is occurring:
The helper function Connect-SQLAnalysis does not have correct error handling. If connection fails it fails with a error message from the the SMO object model which is hard to determine where the error originated.

Also the throw is using a named parameter that does not exist. So the error message can never be thrown. It will just report back that the -Message is an unknown parameter.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Mar 11, 2017
@johlju johlju self-assigned this Mar 11, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Mar 11, 2017
Connect-SQLAnalysis now has correct error handling, and throw does not used the unknown namned parameter '-Message' (issue dsccommunity#436).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Mar 13, 2017
Connect-SQLAnalysis now has correct error handling, and throw does not used the unknown namned parameter '-Message' (issue dsccommunity#436).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Mar 25, 2017
Connect-SQLAnalysis now has correct error handling, and throw does not used the unknown namned parameter '-Message' (issue dsccommunity#436).
johlju added a commit that referenced this issue Mar 25, 2017
#438)

- Changes to xSQLServerSetup
  - Added a note to the README.md saying that it is not possible to add or remove features from a SQL Server failover cluster (issue #433).
  - Changed so that it reports false if the desired state is not correct (issue #432).
    - Added a test to make sure we always return false if a SQL Server failover cluster is missing features.
  - Helper function Connect-SQLAnalysis
    - Now has correct error handling, and throw does not used the unknown named parameter '-Message' (issue #436)
    - Added tests for Connect-SQLAnalysis
    - Changed to localized error messages.
    - Minor changes to error handling.
@johlju johlju removed their assignment Mar 25, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant