Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke-SetupAction: New arguments for setup.exe with the GA release of SQL Server 2022 #1798

Closed
johlju opened this issue Nov 24, 2022 · 4 comments · Fixed by #1825
Closed

Invoke-SetupAction: New arguments for setup.exe with the GA release of SQL Server 2022 #1798

johlju opened this issue Nov 24, 2022 · 4 comments · Fixed by #1825
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Nov 24, 2022

It seems there has been new arguments added (at least one) and values for arguments has been changed (at least 'ARC' seems to have changed) for GA version of SQL Server 2022.

The private function Invoke-SetupAction should be changed to reflect that, and also any public command that are affected by it.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Nov 24, 2022
@johlju johlju mentioned this issue Nov 24, 2022
Open
@johlju johlju mentioned this issue Dec 24, 2022
Merged
9 tasks
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jan 1, 2023
@sara921-spec
Copy link
Contributor

hi @johlju Does the new parameter propertycoveredbysa included in the new Sqldsc release? kind of fails for me.

@johlju
Copy link
Member Author

johlju commented Jul 31, 2024

The property ProductCoveredBySA is available in the command Install-SqlDscServer. If there an issue with it or a resource, please open a separate issue. 🙂

@sara921-spec
Copy link
Contributor

sara921-spec commented Jul 31, 2024 via email •
edited
Loading

@johlju
Copy link
Member Author

johlju commented Jul 31, 2024

There are currently no resource that are using Install-SqlDscResource, until then that parameter must be added to SqlSetup resource. Please add that to an issue and I'm happy to review a PR that make that change.

@sara921-spec sara921-spec mentioned this issue Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Commands support SQL Server 2022 johlju/SqlServerDsc
2 participants
@johlju @sara921-spec