Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: GitVersion used in pipeline wrongly configured #1674

Closed
johlju opened this issue Jan 16, 2021 · 0 comments · Fixed by #1675
Closed

SqlServerDsc: GitVersion used in pipeline wrongly configured #1674

johlju opened this issue Jan 16, 2021 · 0 comments · Fixed by #1675
Labels
bug The issue is a bug. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.

Comments

@johlju
Copy link
Member

johlju commented Jan 16, 2021

The component gitversion that is used in the pipeline was wrongly configured when the repository moved to the new default branch main. It throws and error when using newer versions of GitVersion.

ERROR [01/16/21 13:31:41:37] An unexpected error occurred:
GitVersion.Configuration.ConfigurationException: Branch configuration 'feature' defines these 'source-branches' that are not configured: '[main]'

The part of GitVersion.yml:

  feature:
    tag: useBranchName
    increment: Minor
    regex: f(eature(s)?)?[\/-]
    source-branches: ['main']
  hotfix:
    tag: fix
    increment: Patch
    regex: (hot)?fix(es)?[\/-]
    source-branches: ['main']

must be changed to

  feature:
    tag: useBranchName
    increment: Minor
    regex: f(eature(s)?)?[\/-]
    source-branches: ['master']
  hotfix:
    tag: fix
    increment: Patch
    regex: (hot)?fix(es)?[\/-]
    source-branches: ['master']

This is due to that the key master is hard-coded into GitVersions configuration file, and the key source-branches: must refer to a branch listed under the key branches: (which is in this case the hard-coded key master:).

@johlju johlju added bug The issue is a bug. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'. in progress The issue is being actively worked on by someone. labels Jan 16, 2021
johlju added a commit that referenced this issue Jan 19, 2021
- SqlServerDsc
  - The component `gitversion` that is used in the pipeline was wrongly configured
    when the repository moved to the new default branch `main`. It no longer throws
    an error when using newer versions of GitVersion (issue #1674).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant