BREAKING CHANGE: SqlLogin: Enforces parameters even if they are not in the configuration

[johlju]

Details of the scenario you tried and the problem that is occurring

The resource SqlLogin is enforcing parameters to a default value even if the user did not opt-in to enforce it in a configuration. That means if a user leaves out for example the parameter LoginPasswordExpirationEnabled from the configuration then the resource will set its default value even if the users did not want to.

Verbose logs showing the problem

not available

Suggested solution to the issue

These parameters should no longer have default values.

SqlServerDsc/source/DSCResources/DSC_SqlLogin/DSC_SqlLogin.psm1

Lines 164 to 174 in 5ab05bd

	[Parameter()]
	[System.Boolean]
	$LoginMustChangePassword = $true,
	[Parameter()]
	[System.Boolean]
	$LoginPasswordExpirationEnabled = $true,
	[Parameter()]
	[System.Boolean]
	$LoginPasswordPolicyEnforced = $true,

The parameters should never be enforced unless the are part of the configuration.

For example, this evaluation:

SqlServerDsc/source/DSCResources/DSC_SqlLogin/DSC_SqlLogin.psm1

Line 207 in 5ab05bd

if ( $login.PasswordPolicyEnforced -ne $LoginPasswordPolicyEnforced )

should have been:

if ($PSBoundParameters.ContainsKey('PasswordPolicyEnforced') -and $login.PasswordPolicyEnforced -ne $LoginPasswordPolicyEnforced)

The DSC configuration that is used to reproduce the issue (as detailed as possible)

If the SQL login exist with the LoginPasswordExpirationEnabled set to $false then this configuration will change the LoginPasswordExpirationEnabled to $true even if it is not part of the configuration.

SqlLogin 'Add_WindowsGroup'
{
    Name                 = 'CONTOSO\User1'
    LoginType            = 'WindowsUser'
    InstanceName         = 'DSC'
}

SQL Server edition and version the target node is running

All

SQL Server PowerShell modules present on the target node

not applicable

The operating system the target node is running

not applicable

Version and build of PowerShell the target node is running

not applicable

Version of the DSC module that was used

main

[bozho]

@johlju I've hit this problem with an SqlLogin resource disabling sa login on new deployments.

Submitted a patch, let me know if you think I should add some tests.