Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc.Common: Connect-SQL should have a parameter set #1403

Closed
johlju opened this issue Jul 16, 2019 · 0 comments · Fixed by #1410
Closed

SqlServerDsc.Common: Connect-SQL should have a parameter set #1403

johlju opened this issue Jul 16, 2019 · 0 comments · Fixed by #1410
Assignees
@johlju
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 16, 2019

If providing SetupCredential without adding the parameter LoginType the resource still using integrated login. I suggets making the SetupCredential and LoginType a parameter set so both parameters could be made mandatory. If the parameter set is not available, then default to login in as integrated.

https://github.com/PowerShell/SqlServerDsc/blob/2d37a930d957d2bbe148d118a5065a2f6f33d29e/Modules/SqlServerDsc.Common/SqlServerDsc.Common.psm1#L961-L970
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jul 16, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 18, 2019
@johlju
Changes to helper function Connect-SQL
25d87a0 
- Connect-SQL now uses parameter sets to more intuitive evaluate that
  the correct parameters are used in different scenarios (issue dsccommunity#1403).
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 18, 2019
@johlju johlju mentioned this issue Jul 18, 2019
Merged
9 tasks
@johlju johlju self-assigned this Jul 18, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 22, 2019
@johlju
Changes to helper function Connect-SQL
a66fcde 
- Connect-SQL now uses parameter sets to more intuitive evaluate that
  the correct parameters are used in different scenarios (issue dsccommunity#1403).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 22, 2019
@johlju
Changes to helper function Connect-SQL
5d84a13 
- Connect-SQL now uses parameter sets to more intuitive evaluate that
  the correct parameters are used in different scenarios (issue dsccommunity#1403).
johlju added a commit that referenced this issue Jul 27, 2019
@johlju
SqlServerDsc: Changes to helper function Connect-SQL (#1410)
81a68ce 
- Changes to SqlServerDsc
  - Changes to helper function Connect-SQL
    - Connect-SQL now uses parameter sets to more intuitive evaluate that
      the correct parameters are used in different scenarios (issue #1403).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Changes to helper function Connect-SQL johlju/SqlServerDsc
1 participant
@johlju