SqlDatabaseDefaultLocation: When changing the Backup file path second test run fails

[johlju]

Details of the scenario you tried and the problem that is occurring

When changing the backup file path to a path that ends with a backslash, the second test run fails because the path returned does not have the backslash.

For example:

BackupFilePath  = 'C:\Backups\'

Verbose logs showing the problem

https://ci.appveyor.com/project/johlju/sqlserverdsc/builds/23134148/job/63encldpywgofimq?fullLog=true

VERBOSE: [APPVYR-WIN]: LCM:  [ Start  Test     ]
VERBOSE: [APPVYR-WIN]: LCM:  [ Start  Resource ]  [[File]SQLBackupPath]
VERBOSE: [APPVYR-WIN]: LCM:  [ Start  Test     ]  [[File]SQLBackupPath]
VERBOSE: [APPVYR-WIN]:                            [[File]SQLBackupPath] The destination object was found and no action is required.
VERBOSE: [APPVYR-WIN]: LCM:  [ End    Test     ]  [[File]SQLBackupPath] True in 0.0050 seconds.
VERBOSE: [APPVYR-WIN]: LCM:  [ End    Resource ]  [[File]SQLBackupPath]
VERBOSE: [APPVYR-WIN]: LCM:  [ Start  Resource ]  [[SqlDatabaseDefaultLocation]Integration_Test]
VERBOSE: [APPVYR-WIN]: LCM:  [ Start  Test     ]  [[SqlDatabaseDefaultLocation]Integration_Test]
VERBOSE: [APPVYR-WIN]:                            [[SqlDatabaseDefaultLocation]Integration_Test] Testing the default path for the 'Backup' files.
VERBOSE: [APPVYR-WIN]:                            [[SqlDatabaseDefaultLocation]Integration_Test] Getting default path for 'Backup' for instance 'DSCSQLTEST'.
VERBOSE: [APPVYR-WIN]:                            [[SqlDatabaseDefaultLocation]Integration_Test] Information: PowerShell module SqlServer not found, trying to use older SQLPS module.
VERBOSE: [APPVYR-WIN]:                            [[SqlDatabaseDefaultLocation]Integration_Test] Importing PowerShell module 'SQLPS' with version '1.0' from path 'C:\Program Files (x86)\Microsoft SQL Server\130\Tools\PowerShell\Modules\SQLPS\SQLPS.psd1'.
VERBOSE: [APPVYR-WIN]:                            [[SqlDatabaseDefaultLocation]Integration_Test] Connected to SQL instance 'APPVYR-WIN\DSCSQLTEST'.
VERBOSE: [APPVYR-WIN]:                            [[SqlDatabaseDefaultLocation]Integration_Test] Current default path for 'Backup' is 'C:\Backups' and should be updated to 'C:\Backups\'.
VERBOSE: [APPVYR-WIN]: LCM:  [ End    Test     ]  [[SqlDatabaseDefaultLocation]Integration_Test] False in 1.1600 seconds.
VERBOSE: [APPVYR-WIN]: LCM:  [ End    Resource ]  [[SqlDatabaseDefaultLocation]Integration_Test]
VERBOSE: [APPVYR-WIN]: LCM:  [ End    Test     ]     Completed processing test operation. The operation returned False.
VERBOSE: [APPVYR-WIN]: LCM:  [ End    Test     ]    in  1.2570 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 1.278 seconds
      [-] Should return $true when Test-DscConfiguration is run 1.39s
        Expected strings to be the same, but they were different.
        Expected length: 4
        Actual length:   5
        Strings differ at index 0.
        Expected: 'True'
        But was:  'False'
        -----------^
        180:                 Test-DscConfiguration -Verbose | Should -Be 'True'
        at <ScriptBlock>, C:\projects\sqlserverdsc\Tests\Integration\MSFT_SqlDatabaseDefaultLocation.Integration.Tests.ps1: line 180

Suggested solution to the issue

Remove the backslash from the path before using it, both for Test-TargetResource and Set-TargetResource.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

SqlDatabaseDefaultLocation 'Integration_Test'
{
    Type                 = 'Backup'
    Path                 =  'C:\Backups\'
    RestartService       = $true
    ServerName           = $Node.ComputerName
    InstanceName         = $Node.InstanceName
}

SQL Server edition and version the target node is running

2016 and 2017

SQL Server PowerShell modules present on the target node

n/a

The operating system the target node is running

n/a

Version and build of PowerShell the target node is running

n/a

Version of the DSC module that was used ('dev' if using current dev branch)

Dev