Skip to content

Commit

Permalink
BREAKING CHANGE: SqlRole: Resource overhaul for tests (#1631)
Browse files Browse the repository at this point in the history
- SqlRole
  - Major overhaul of resource
  - BREAKING CHANGE: Removed decision making from get-TargetResource; this prevented a simple solution for
    issue #550. it now just tels if a role exists or not. And what members are in that 
    role. MembersToInclude and MembersToExclude now always return $null
  - Added sanitize function (Get-CorrectedMemberParameters) to make it so for the
    sysadmin role SA does not get altered (issue #550)
  - added lots of tests.
  • Loading branch information
Fiander authored Nov 21, 2020
1 parent 56ebcfe commit c7146f9
Show file tree
Hide file tree
Showing 6 changed files with 786 additions and 666 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- SqlRole
- Major overhaul of resource
- BREAKING CHANGE: Removed decision making from get-TargetResource; this prevented a simple solution for
issue #550. it now just tels if a role exists or not. And what members are in that
role. MembersToInclude and MembersToExclude now always return $null
- Added sanitize function (Get-CorrectedMemberParameters) to make it so for the
sysadmin role SA does not get altered. ([issue #550](https://github.com/dsccommunity/SqlServerDsc/issues/550))
- added lots of tests.

### Added

- SqlEndpoint
Expand Down
Loading

0 comments on commit c7146f9

Please sign in to comment.