Skip to content

Commit

Permalink
SqlProtocol: Changes datatype for schema property KeepAlive (#1646)
Browse files Browse the repository at this point in the history
- SqlProtocol
  - Changed KeepAlive Type from UInt16 to Int32 to reflect te actual WMI.ManagementObject (issue #1645).
  • Loading branch information
Fiander authored Dec 12, 2020
1 parent fdc7608 commit 5035d2d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- SqlMaxDop
- Fixes ([issue #396](https://github.com/dsccommunity/SqlServerDsc/issues/396)).
Added three return values in Get-Target resource.
- SqlProtocol
- Changed KeepAlive Type from UInt16 to Int32 to reflect te actual WMI.ManagementObject
Fixes #1645 ([issue #1645](https://github.com/dsccommunity/SqlServerDsc/issues/1645)).

## [15.0.0] - 2020-12-06

Expand Down
6 changes: 3 additions & 3 deletions source/DSCResources/DSC_SqlProtocol/DSC_SqlProtocol.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ function Set-TargetResource
$ListenOnAllIpAddresses,

[Parameter()]
[System.UInt16]
[System.Int32]
$KeepAlive,

[Parameter()]
Expand Down Expand Up @@ -429,7 +429,7 @@ function Test-TargetResource
$ListenOnAllIpAddresses,

[Parameter()]
[System.UInt16]
[System.Int32]
$KeepAlive,

[Parameter()]
Expand Down Expand Up @@ -541,7 +541,7 @@ function Compare-TargetResourceState
$ListenOnAllIpAddresses,

[Parameter()]
[System.UInt16]
[System.Int32]
$KeepAlive,

[Parameter()]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class DSC_SqlProtocol : OMI_BaseResource
[Write, Description("Specifies the host name of the _SQL Server_ to be configured. If the SQL Server belongs to a cluster or availability group specify the host name for the listener or cluster group. Default value is $env:COMPUTERNAME.")] String ServerName;
[Write, Description("Specifies if the protocol should be enabled or disabled.")] Boolean Enabled;
[Write, Description("Specifies to listen on all IP addresses. Only used for the _TCP/IP_ protocol, ignored for all other protocols.")] Boolean ListenOnAllIpAddresses;
[Write, Description("Specifies the keep alive duration in milliseconds. Only used for the _TCP/IP_ protocol, ignored for all other protocols.")] UInt16 KeepAlive;
[Write, Description("Specifies the keep alive duration in milliseconds. Only used for the _TCP/IP_ protocol, ignored for all other protocols.")] SInt32 KeepAlive;
[Write, Description("Specifies the name of the named pipe. Only used for the _Named Pipes_ protocol, ignored for all other protocols.")] String PipeName;
[Write, Description("If set to `$true` then the any attempt by the resource to restart the service is suppressed. The default value is `$false`.")] Boolean SuppressRestart;
[Write, Description("Timeout value for restarting the _SQL Server_ services. The default value is `120` seconds.")] UInt16 RestartTimeout;
Expand Down

0 comments on commit 5035d2d

Please sign in to comment.