Skip to content

Commit

Permalink
Fix localization hqrm (#2050)
Browse files Browse the repository at this point in the history
  • Loading branch information
johlju authored Oct 26, 2024
1 parent 5677cd5 commit 1bf09ec
Showing 5 changed files with 32 additions and 7 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -5,10 +5,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- SqlSetup
- Fixed issue with AddNode where cluster IP information was not being passed to
setup.exe. ([issue #1171](https://github.com/dsccommunity/SqlServerDsc/issues/1171))

### Fixed

- SqlServerDsc
- Fix localization tests.

## [17.0.0] - 2024-09-30

### Added
8 changes: 7 additions & 1 deletion RequiredModules.psd1
Original file line number Diff line number Diff line change
@@ -36,7 +36,13 @@
'DscResource.Common' = 'latest'

# Analyzer rules
'DscResource.AnalyzerRules' = 'latest'
'DscResource.AnalyzerRules' = @{
Version = 'latest'
Parameters = @{
AllowPrerelease = $true
}
}

'Indented.ScriptAnalyzerRules' = 'latest'

# Dependency for integration tests
14 changes: 12 additions & 2 deletions build.yaml
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@ BuildWorkflow:
- Create_Changelog_Release_Output

docs:
- Clean_WikiContent_Folder
- Check_SqlServer_Availability
- Generate_Conceptual_Help
- Generate_Wiki_Content
@@ -46,13 +47,22 @@ BuildWorkflow:
try
{
[Microsoft.SqlServer.Management.Smo.Server] -as [Type] | Out-Null
[Microsoft.SqlServer.Management.Smo.Wmi.Service] -as [Type] | Out-Null
}
catch
{
throw 'The SqlServer types are not available. Please install the SqlServer module or load SMO stubs types and try again.'
Write-Error -Message "Both the SqlServer namespaces Microsoft.SqlServer.Management.Smo or Microsoft.SqlServer.Management.Smo.Wmi are not available. Please install the SqlServer module.`nBy using PSResourceGet: Save-PSResource -Name SqlServer -Prerelease -Repository PSGallery -TrustRepository -Path .\output\RequiredModules\" -ErrorAction 'Stop'
}
}
Clean_WikiContent_Folder: |
{
# Clean output/WikiContent folder
if (Test-Path -Path './output/WikiContent')
{
Remove-Item -Path './output/WikiContent' -Recurse -Force
}
}
####################################################
# ModuleBuilder Configuration #
####################################################
@@ -188,7 +198,7 @@ DscResource.DocGenerator:
- '\*(.+?)\*' # Match Italic (asterisk)
Publish_GitHub_Wiki_Content:
Debug: false
Generate_Wiki_Content:
Generate_Markdown_For_DSC_Resources:
MofResourceMetadata:
Type: MofResource
Category: Resources
4 changes: 1 addition & 3 deletions source/Modules/SqlServerDsc.Common/SqlServerDsc.Common.psm1
Original file line number Diff line number Diff line change
@@ -358,9 +358,7 @@ function Test-PendingRestart
{
[CmdletBinding()]
[OutputType([System.Boolean])]
param
(
)
param ()

$getRegistryPropertyValueParameters = @{
Path = 'HKLM:\SYSTEM\CurrentControlSet\Control\Session Manager'
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Credential Overview
---
Category: Usage
---

# Credential overview

## Group Managed Service Account

0 comments on commit 1bf09ec

Please sign in to comment.