Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPTrustedRootAuthority - Fix Error while adding Trusted Root Authority via CertificateThumbprint #1418

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

hollanjs
Copy link
Contributor

@hollanjs hollanjs commented Jan 24, 2023

Pull Request (PR) description

Added -Recurse to Get-ChildItem when Set-TargetResource attempts to obtain reference to the certificate by thumbprint.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@hollanjs hollanjs changed the title Fix issue 1417 Fix issue 1417 - SPTrustedRootAuthority - Error while adding Trusted Root Authority via CertificateThumbprint Jan 24, 2023
@hollanjs
Copy link
Contributor Author

I've submitted an issue with the CertificateDsc module to move the Find-Certificate function to the DSCResource.Common module. This should allow a better refactoring of the SP resources that need to obtain references to certificates in the local machine, as well as reduce the amount of code and tests that need to be maintained and updated here.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1418 (c4cf42f) into master (e294818) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1418   +/-   ##
======================================
  Coverage      84%     84%           
======================================
  Files         145     145           
  Lines       22645   22645           
======================================
+ Hits        19074   19076    +2     
+ Misses       3571    3569    -2     
Impacted Files Coverage Δ
...stedRootAuthority/MSFT_SPTrustedRootAuthority.psm1 88% <100%> (ø)
...s/MSFT_SPInstallPrereqs/MSFT_SPInstallPrereqs.psm1 88% <0%> (+<1%) ⬆️

@hollanjs hollanjs changed the title Fix issue 1417 - SPTrustedRootAuthority - Error while adding Trusted Root Authority via CertificateThumbprint SPTrustedRootAuthority - Fix Error while adding Trusted Root Authority via CertificateThumbprint Jan 24, 2023
@hollanjs hollanjs marked this pull request as ready for review January 24, 2023 17:48
@hollanjs hollanjs requested a review from ykuijs as a code owner January 24, 2023 17:48
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 0cc9fef into dsccommunity:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPTrustedRootAuthority - Error while adding Trusted Root Authority via CertificateThumbprint
2 participants