-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent ResourceHelper and Common cmdlets from being exported - Fixes #213 #214
Conversation
…d to resolve conflicts with other resource modules.
Codecov Report
@@ Coverage Diff @@
## dev #214 +/- ##
====================================
+ Coverage 96% 96% +<1%
====================================
Files 17 17
Lines 1222 1273 +51
====================================
+ Hits 1174 1225 +51
Misses 48 48 |
Reviewed 20 of 20 files at r1. Tests/Integration/ModuleConflict.Tests.ps1, line 37 at r1 (raw file):
Same comment as in xStorage Comments from Reviewable |
This too could use a global search replace to correct the style, but I'll do this in a separate issue. Review status: 19 of 20 files reviewed at latest revision, 1 unresolved discussion. Tests/Integration/ModuleConflict.Tests.ps1, line 37 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
Thanks again so much for your help @johlju |
This resolves a high priority issue with newer versions of xNetworking, xCertificate, xStorage and xDFS conflicting with each other because the ResourceHelper cmdlets are being exported due to the way each resource imported them (using the PSD1 nested modules array).
This should be resolved in xCertificate, xStorage and xDFS as well to ensure no other conflicts.
This also contains a new integration test that will check for any further conflicts between resource modules. At some point it might be possible to move this test into the DSCResource.Tests common tests to provide more comprehensive conflict prevention. However, because the conflicts will potentially be between three different modules the number of modules compared will have to go in over time.
This fixes #213
This change is