Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Unit Tests Don't Display Resource Name in Describe #405

Closed
PlagueHO opened this issue Jun 7, 2019 · 0 comments · Fixed by #406
Closed

Some Unit Tests Don't Display Resource Name in Describe #405

PlagueHO opened this issue Jun 7, 2019 · 0 comments · Fixed by #406
Assignees
@PlagueHO
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Jun 7, 2019

The resource unit test don't display the resource name in the Describe blocks because the variable used is scoped incorrectly:
https://github.com/PowerShell/NetworkingDsc/blob/dev/Tests/Unit/MSFT_NetAdapterState.Tests.ps1#L46

We have moved away from using a variable here, preferring to use a literal.
@PlagueHO PlagueHO self-assigned this Jun 7, 2019
@PlagueHO PlagueHO added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Jun 7, 2019
@PlagueHO PlagueHO mentioned this issue Jun 7, 2019
Merged
9 tasks
PlagueHO added a commit that referenced this issue Jun 18, 2019
@PlagueHO
Merge pull request #406 from PlagueHO/Issue-405
22d9cf5 
Clean up Unit Tests - Fixes #405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up Unit Tests - Fixes #405
1 participant
@PlagueHO