Invoke-DscResourceTest support Pester 5

[johlju]

Fixed

• Update build.yaml to support latest ModuleBuilder.
• Pinned required module Pester to 4.10.1.
• Update CONTRIBUTING.md.

Changes

• The cmdlet Invoke-DscResourceTest support running test in Pester 5.

---

This change is 

[PlagueHO]

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @johlju)

---

source/Public/Invoke-DscResourceTest.ps1, line 20 at r1 (raw file):

        [Alias('Script', 'relative_path')]
        [System.Object[]]
        ${Path},

FYI, Nitpick: Is there any reason why we're using the curly braces round the variable name in all of these?

---

source/Public/Invoke-DscResourceTest.ps1, line 24 at r1 (raw file):

        [Parameter(Position = 2)]
        [Alias('Name')]
        [string[]]

For consistency can we use the full typename?

---

source/Public/Invoke-DscResourceTest.ps1, line 110 at r1 (raw file):

            'ByModuleNameOrPath'
            {
                Write-Verbose "Calling DscResource Test by Module Name (Or Path)"

Positional parameter here - also should use single quotes.

---

source/Public/Invoke-DscResourceTest.ps1, line 124 at r1 (raw file):

            'ByModuleSpecification'
            {
                Write-Verbose "Calling DscResource Test by Module Specification"

Positional parameter here - also should use single quotes.

[johlju]

I fixed the style thorughout.

Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @PlagueHO)

---

source/Public/Invoke-DscResourceTest.ps1, line 20 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

FYI, Nitpick: Is there any reason why we're using the curly braces round the variable name in all of these?

No reason unless the parameter names have spaces in them. Removed. :)

---

source/Public/Invoke-DscResourceTest.ps1, line 24 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

For consistency can we use the full typename?

Done.

---

source/Public/Invoke-DscResourceTest.ps1, line 110 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Positional parameter here - also should use single quotes.

Done.

---

source/Public/Invoke-DscResourceTest.ps1, line 124 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Positional parameter here - also should use single quotes.

Done.

[johlju]

@PlagueHO Ready for review again.

[PlagueHO]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[johlju]

I will release this as soon as the tests passes. Now it is just the hard task of converting the HQRM tests.