-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Wiki, ASCII encoding parameter values (Issue #45) #46
Fixing Wiki, ASCII encoding parameter values (Issue #45) #46
Conversation
…ASCII)' with 'ascii'.
Note that the failing tests seem to all be related to the build tasks and also failed locally for me, prior to any changes. For example...
I'm not clear enough on this module's build is expected/designed to work (and it looks a little new/unstable so not wanting to start digging into this as there might be a quick/easy answer/fix) so I'll leave my changes in this PR for when those are resolved. Shout if you've any questions |
Closing an reopening to kick off the tests again. |
I'm not sure what is going on. The test that fails should just dot-source using the alias that points to the build task script. It is meant to verify that the alias points to a script that parse correctly 🤔 It worked last time I worked on this but something might have changed. I need to dig into it to understand why it happening, but it is gonna take a while. |
I will try to look into this during next week so we can get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SphenicPaul)
Couldn't let it go, so I fixed the problem. Will merge this shortly! Thank you @SphenicPaul! 😃 |
Pull Request
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Fixes #45
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is