Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Wiki, ASCII encoding parameter values (Issue #45) #46

Merged

Conversation

SphenicPaul
Copy link
Contributor

@SphenicPaul SphenicPaul commented Dec 13, 2020

Pull Request

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #45

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • Integration tests added/updated (where possible).
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@SphenicPaul
Copy link
Contributor Author

Note that the failing tests seem to all be related to the build tasks and also failed locally for me, prior to any changes. For example...

  • Task 'Generate_Conceptual_Help': Cannot add tasks.
  • Task 'Generate_Wiki_Content': Cannot add tasks.
  • Task 'Publish_Gihub_Wiki_Content': Cannot add tasks.

I'm not clear enough on this module's build is expected/designed to work (and it looks a little new/unstable so not wanting to start digging into this as there might be a quick/easy answer/fix) so I'll leave my changes in this PR for when those are resolved.

Shout if you've any questions

@johlju johlju added the needs review The pull request needs a code review. label Jan 2, 2021
@johlju
Copy link
Member

johlju commented Jan 2, 2021

Closing an reopening to kick off the tests again.

@johlju johlju closed this Jan 2, 2021
@johlju johlju reopened this Jan 2, 2021
@johlju
Copy link
Member

johlju commented Jan 2, 2021

I'm not sure what is going on. The test that fails should just dot-source using the alias that points to the build task script. It is meant to verify that the alias points to a script that parse correctly 🤔 It worked last time I worked on this but something might have changed. I need to dig into it to understand why it happening, but it is gonna take a while.

@johlju
Copy link
Member

johlju commented Jan 17, 2021

I will try to look into this during next week so we can get this merged.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SphenicPaul)

@johlju
Copy link
Member

johlju commented Jan 17, 2021

Couldn't let it go, so I fixed the problem. Will merge this shortly! Thank you @SphenicPaul! 😃

@johlju johlju removed the needs review The pull request needs a code review. label Jan 17, 2021
@johlju johlju merged commit e02ce1e into dsccommunity:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set-WikiModuleVersion: Invalid Encoding parameter value
2 participants