Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing documentation in the README.md #25

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Fix missing documentation in the README.md #25

merged 1 commit into from
Feb 26, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Feb 26, 2020 •
edited
Loading

Pull Request

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • Integration tests added/updated (where possible).
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Feb 26, 2020
gaelcolas
gaelcolas approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@johlju johlju merged commit e161d60 into dsccommunity:master Feb 26, 2020
@johlju johlju deleted the fix/documentation branch February 26, 2020 17:47
@johlju johlju removed the needs review The pull request needs a code review. label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaelcolas gaelcolas gaelcolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate_Wiki_Content: The task should be documented in the README.md
2 participants
@johlju @gaelcolas