-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to publish to the Wiki #84
Comments
|
@phbits could you please look into this? It failed after the recent PR too. |
I did a debug branch (main...johlju:debug-publish-wiki) to try to reproduce it to help figure this out. Below is the output for the debug run.
|
With the latest PR #87 this still fails:
|
@phbits the lates changes did not help. 😕 Do you have tim to look at it again? 🙂 |
It seems it doesn't ger past the first DscResource.DocGenerator/source/tasks/Publish_GitHub_Wiki_Content.build.ps1 Lines 174 to 175 in 1420a68
Because it never outputs this: DscResource.DocGenerator/source/tasks/Publish_GitHub_Wiki_Content.build.ps1 Lines 192 to 193 in 1420a68
|
@phbits it seems the error is generated when running on a Linux build worker. It works better on a Windows build worker, but fails with another error there. Linux:
Windows:
|
So first issue on Linux is that we try to start |
And the error on Windows might be a left over |
Wow, you're fast! Just got a debug pipeline up and running only to come back and find you've fixed it! 😲 |
I had some time to kill in front of the TV. Not sure I fixed anything yet. 😉 But first issue should be solved though, not sure about the other one. |
Azure Pipelines is extremely slow tonight so take a while for things to run. :/ |
Applied the debug pipeline you setup earlier to the new PR branch and I'm at >15min and counting for build & package. :sigh: |
Yeah it seems it is getting worse. The first build phase took 22 minutes, and the tests have not even started after 35 minutes. |
I might not be able to merge the PR i sent in before I need to go to sleep, if so I merge it tomorrow morning. |
I merged the changes so you can test the pipeline with all changes in main now. |
Wahoo, that worked! Great job! 🥳 MS posted an Azure Pipelines incident: https://status.dev.azure.com/_event/249267909 |
@phbits it seems there are still issues left (or at least one) because the WIki was not updated. The task passed, but the Wiki did not update the version number or the latest commit is not yesterday. See here: https://github.com/dsccommunity/DscResource.DocGenerator/wiki |
I had a few minute to look this over. Seems we have a bug in this row. The last DscResource.DocGenerator/source/Public/Publish-WikiContent.ps1 Lines 118 to 119 in d23d17d
I will send in a PR shortly. I think we should make it easier and just set |
So that was not it... Added debug output to the pipeline by adding the following to build.yml
It shows that the URL contain a newline (see below) - so I have sent in another PR that resolves this in
|
The lates fix seems to have solved the issue, it now published the wiki, a new commit was pushed and the version number was changed on the first page. @phbits thanks for the time you put on this! Appreciate very much your help to resolve this. 🙂 We still need to add error handling so the task fail, but we can track and fix that in issue #90. It is hard to find these error in the review, and without proper integration tests they are not caught - but not sure how to create "real-world" integration test. 🤔 |
It seems the latest PR that was merged did not work as expected, it failed to publish to the Wiki when dogfooding itself. It will hopefully be resolved by PR #80.
See error https://dev.azure.com/dsccommunity/DscResource.DocGenerator/_build/results?buildId=4801&view=logs&j=5d0a9c4e-8741-5118-af45-406a30fe661c&t=bda0b158-a237-516f-c1d0-31339587c5b5&l=146
Raw output here (if the link above do not work):
Originally posted by @johlju in #80 (comment)
The text was updated successfully, but these errors were encountered: