Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #95

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Fix unit tests #95

merged 1 commit into from
Dec 30, 2022

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 30, 2022

Pull Request (PR) description

  • Fixed unit tests to easier run test both from command line and inside
    Visual Studio Code.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #95 (04b0779) into main (052cfde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           main   #95   +/-   ##
==================================
  Coverage    91%   91%           
==================================
  Files        31    31           
  Lines       568   568           
==================================
  Hits        519   519           
  Misses       49    49           

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit efc0408 into dsccommunity:main Dec 30, 2022
@johlju johlju deleted the f/unit-tests branch December 30, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant