Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing tasks module #78

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 18, 2022

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #78 (6524548) into main (b2fb02c) will not change coverage.
The diff coverage is n/a.

❗ Current head 6524548 differs from pull request most recent head 82178e5. Consider uploading reports for the commit 82178e5 to get more accurate results

Impacted file tree graph

@@        Coverage Diff         @@
##           main   #78   +/-   ##
==================================
  Coverage    92%   92%           
==================================
  Files        26    26           
  Lines       469   469           
==================================
  Hits        433   433           
  Misses       36    36           

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, 23 of 23 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit fbd65c3 into dsccommunity:main Jul 18, 2022
@johlju johlju deleted the fix/pipeline-files branch July 18, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant