Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert-Module: Reduce verbose output #67

Merged
merged 8 commits into from
Mar 24, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 20, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from PlagueHO March 20, 2021 07:39
@johlju
Copy link
Member Author

johlju commented Mar 20, 2021

@PlagueHO when you have time can you review this one. There is no hurry.

@johlju johlju added the needs review The pull request needs a code review. label Mar 20, 2021
@johlju johlju changed the title Assert-Module: Reduce when verbose message are outputted Assert-Module: Reduce verbose output Mar 20, 2021
@johlju johlju requested a review from gaelcolas March 24, 2021 15:42
Copy link
Member

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found one typo. Feel free to merge.

source/Public/Assert-Module.ps1 Outdated Show resolved Hide resolved
@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Mar 24, 2021
@johlju johlju merged commit 8bb53ee into dsccommunity:main Mar 24, 2021
@johlju johlju deleted the fix/assert-module branch March 24, 2021 16:12
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert-Module: Outputs unnecessary verbose statements due to -ListAvailable is used each time
2 participants