-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert-Module: Reduce verbose output #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PlagueHO when you have time can you review this one. There is no hurry. |
johlju
changed the title
Assert-Module: Reduce when verbose message are outputted
Assert-Module: Reduce verbose output
Mar 20, 2021
gaelcolas
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only found one typo. Feel free to merge.
johlju
commented
Mar 24, 2021
johlju
added
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
and removed
needs review
The pull request needs a code review.
labels
Mar 24, 2021
johlju
removed
the
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
label
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Assert-Module
-ImportModule -Force
using
Get-Module -ListAvailable
if the module that is asserted isalready in the session (issue
Assert-Module:
Outputs unnecessary verbose statements due to-ListAvailable
is used each time #66).This Pull Request (PR) fixes the following issues
Assert-Module:
Outputs unnecessary verbose statements due to-ListAvailable
is used each time #66Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is