Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cmdlet Get-ComputerName #60

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 24, 2020

Pull Request (PR) description

  • Added cmdlet Get-ComputerName which can be used to returns the computer
    name cross-plattform. The variable $env:COMPUTERNAME does not exist
    cross-platform which hinders development and testing on macOS and Linux.
    Instead this cmdlet can be used to get the computer name cross-plattform.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Dec 24, 2020
Copy link
Member

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@johlju johlju merged commit 4c472a3 into dsccommunity:master Dec 24, 2020
@johlju johlju deleted the f/get-computername branch December 24, 2020 19:01
@johlju johlju removed the needs review The pull request needs a code review. label Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants