Removing IncludeDesiredState and IncludeValue parameter in Test-DscParameterState and correct typo #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing IncludeInDesiredState and IncludeValue parameters in Test-DscParameterState. Changed Compare-DscParameterState typo in help and call to of Test-DscParameterSate.
gaelcolas
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
looks good at first time. Waiting on build to approve.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NicolasBn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Correct typo of my last PR.
Removing IncludeDesiredState and IncludeValue parameters in Test-DscParameterState.
I added those parameters to correct an exception when Compare-DscParameterState call Test-DscParameterState with splatting.
But this was nonsense.
Now, Compare-DscParameterState removes IncludeDesiredState and IncludeValue in splatting.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is