Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-LocalizedData: Add DefaultUICulture Default Parameter #34

Merged

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented May 3, 2020

Pull Request (PR) description

This PR adds a default value of en-US to the DefaultUICulture parameter of the Get-LocalizedData function.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@X-Guardian X-Guardian marked this pull request as ready for review May 3, 2020 18:31
@X-Guardian
Copy link
Contributor Author

@johlju, can you review?

@johlju johlju added the needs review The pull request needs a code review. label May 10, 2020
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 8a9da33 into dsccommunity:master May 10, 2020
@johlju johlju removed the needs review The pull request needs a code review. label May 10, 2020
@johlju
Copy link
Member

johlju commented May 10, 2020

Thanks for tagging me, it is the only way I find these unless I stumble upon them by accident. :)

Great addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-LocalizedData: Add Default for DefaultUICulture Parameter
2 participants