Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvertTo-CimInstance add parameters for ClassName and Namespace #130

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

dan-hughes
Copy link
Contributor

@dan-hughes dan-hughes commented Sep 29, 2024

Pull Request (PR) description

Add parameters to allow reuse

This Pull Request (PR) fixes the following issues

Fixes #128

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92%. Comparing base (00506d4) to head (f56b9b1).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #130   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        41     41           
  Lines       700    700           
===================================
  Hits        650    650           
  Misses       50     50           
Flag Coverage Δ
92% <100%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
source/Public/ConvertTo-CimInstance.ps1 100% <100%> (ø)

@dan-hughes
Copy link
Contributor Author

@johlju

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-hughes)

@johlju
Copy link
Member

johlju commented Sep 30, 2024

@dan-hughes awesome work as usually! 🙂

@johlju johlju merged commit b172255 into dsccommunity:main Sep 30, 2024
11 checks passed
@dan-hughes dan-hughes deleted the fix-issue128 branch September 30, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConvertTo-CimInstance - Add parameters for ClassName and Namespace
2 participants