Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command New-ErrorRecord #118

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 23, 2024

Pull Request (PR) description

  • New-ErrorRecord
    • New command that creates and returns an [System.Management.Automation.ErrorRecord]
      (issue #99).
  • New-ArgumentException
    • Now uses the new command New-ErrorRecord.
  • New-InvalidDataException
    • Now uses the new command New-ErrorRecord.
  • New-InvalidOperationException
    • Now uses the new command New-ErrorRecord.
  • New-InvalidResultException
    • Now uses the new command New-ErrorRecord.
  • New-NotImplementedException
    • Now uses the new command New-ErrorRecord.
  • New-ObjectNotFoundException
    • Now uses the new command New-ErrorRecord.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df361a2) 92% compared to head (d38da9b) 92%.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #118   +/-   ##
===================================
- Coverage    92%    92%   -1%     
===================================
  Files        38     39    +1     
  Lines       668    655   -13     
===================================
- Hits        621    608   -13     
  Misses       47     47           
Files Coverage Δ
source/Public/New-ArgumentException.ps1 100% <100%> (ø)
source/Public/New-ErrorRecord.ps1 100% <100%> (ø)
source/Public/New-InvalidDataException.ps1 100% <100%> (ø)
source/Public/New-InvalidOperationException.ps1 100% <100%> (ø)
source/Public/New-InvalidResultException.ps1 100% <100%> (ø)
source/Public/New-NotImplementedException.ps1 100% <100%> (ø)
source/Public/New-ObjectNotFoundException.ps1 100% <100%> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit fea4a5d into dsccommunity:main Jan 23, 2024
11 checks passed
@johlju johlju deleted the f/issue-99 branch January 23, 2024 16:54
@johlju johlju removed the needs review The pull request needs a code review. label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New-ErrorRecord: New command
1 participant