Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-PSModulePath: New parameter set #114

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 21, 2024

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c634a4d) 91% compared to head (3106da0) 91%.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #114   +/-   ##
===================================
- Coverage    91%    91%   -1%     
===================================
  Files        37     37           
  Lines       656    664    +8     
===================================
+ Hits        602    609    +7     
- Misses       54     55    +1     
Files Coverage Δ
source/Public/Set-PSModulePath.ps1 90% <90%> (-10%) ⬇️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 1ada77f into dsccommunity:main Jan 21, 2024
11 checks passed
@johlju johlju deleted the f/issue-102 branch January 21, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set-PSModulePath: Support adding Machine and User environment variables to session
1 participant