Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Fix documentation #107

Merged
merged 1 commit into from
May 9, 2023
Merged

SqlServerDsc: Fix documentation #107

merged 1 commit into from
May 9, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented May 9, 2023

Pull Request (PR) description

  • Assert-BoundParameter
    • Fixed example in documentation that were referencing an invalid command name.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #107 (239e327) into main (9d4c630) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #107   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        37     37           
  Lines       645    645           
===================================
  Hits        594    594           
  Misses       51     51           

@johlju johlju merged commit 340605e into main May 9, 2023
@johlju johlju deleted the fix-docs branch May 9, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant