Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test-IsNanoServer - Fixes #9 #10

Merged
merged 3 commits into from
Feb 15, 2020
Merged

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jan 24, 2020

This PR adds Test-IsNanoServer, using the code as suggested in this issue:
dsccommunity/xPSDesiredStateConfiguration#652

This allows for a low risk way of moving xPSDesiredStateConfiguration a faster method of Test-IsNanoServer.


This change is Reviewable

@PlagueHO PlagueHO requested a review from johlju January 24, 2020 23:18
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju
Copy link
Member

johlju commented Jan 25, 2020

Using Reviewable from the phone actually worked 😃

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)


tests/Unit/Public/Test-IsNanoServer.Tests.ps1, line 18 at r1 (raw file):

Mock -CommandName Get-CimInstance

THis cmdlet does not exist on macOS and Linux, so either we skip the test or we mock it using a fake function function Get-CimInstance {} to pass on all OS. I suggest we skip the test on unsupported platforms.

@johlju
Copy link
Member

johlju commented Jan 26, 2020

@PlagueHO I missed that the tests failed yesterday.

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jan 26, 2020
@PlagueHO
Copy link
Member Author

Should be good to go now @johlju

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Feb 15, 2020
@johlju johlju merged commit 06f98c5 into dsccommunity:master Feb 15, 2020
@PlagueHO PlagueHO deleted the Issue-9 branch February 15, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants