-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Test-IsNanoServer - Fixes #9 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Using Reviewable from the phone actually worked 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
tests/Unit/Public/Test-IsNanoServer.Tests.ps1, line 18 at r1 (raw file):
Mock -CommandName Get-CimInstance
THis cmdlet does not exist on macOS and Linux, so either we skip the test or we mock it using a fake function function Get-CimInstance {}
to pass on all OS. I suggest we skip the test on unsupported platforms.
@PlagueHO I missed that the tests failed yesterday. |
Should be good to go now @johlju |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
This PR adds Test-IsNanoServer, using the code as suggested in this issue:
dsccommunity/xPSDesiredStateConfiguration#652
This allows for a low risk way of moving xPSDesiredStateConfiguration a faster method of Test-IsNanoServer.
This change is