Skip to content

Commit

Permalink
Fix missed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@johlju
johlju committed Jun 23, 2021
1 parent 9d29362 commit dafb626
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion tests/QA/module.tests.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Describe 'Quality for module' -Tags 'TestQuality' {
}

It 'Should have a unit test for <Name>' -TestCases $testCases {
Get-ChildItem 'tests\' -Recurse -Include "$Name.Tests.ps1" | Should -Not -BeNullOrEmpty
Get-ChildItem -Path 'tests\' -Recurse -Include "$Name.Tests.ps1" | Should -Not -BeNullOrEmpty
}

It 'Should pass Script Analyzer for <Name>' -TestCases $testCases -Skip:(-not $scriptAnalyzerRules) {
Expand Down
36 changes: 18 additions & 18 deletions tests/Unit/Public/Compare-DscParameterState.Tests.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When testing single values' {
BeforeAll{
BeforeAll {
$currentValues = @{
String = 'a string'
Bool = $true
Expand All @@ -30,7 +30,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When all values match' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand Down Expand Up @@ -101,7 +101,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a boolean is mismatched' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $false
Expand Down Expand Up @@ -274,7 +274,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a type is mismatched' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand Down Expand Up @@ -312,7 +312,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a type is mismatched but TurnOffTypeChecking is used' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand All @@ -335,7 +335,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a value is mismatched but ExcludeProperties is used to exclude then' {
BeforeAll{
BeforeAll {
$desiredValues = @{
String = 'some other string'
Bool = $true
Expand Down Expand Up @@ -368,7 +368,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a value is mismatched but it is not in Properties then' {
BeforeAll{
BeforeAll {
$desiredValues = @{
String = 'some other string'
Bool = $true
Expand Down Expand Up @@ -418,7 +418,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a value is mismatched but it is in Properties then' {
BeforeAll{
BeforeAll {
$properties = @(
'String'
'Bool'
Expand Down Expand Up @@ -460,7 +460,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When testing single values and use IncludeInDesiredState parameter' {
BeforeAll{
BeforeAll {
$currentValues = @{
String = 'a string'
Bool = $true
Expand All @@ -476,7 +476,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When all values match' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand Down Expand Up @@ -541,7 +541,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a boolean is mismatched' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $false
Expand Down Expand Up @@ -692,7 +692,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a type is mismatched' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand Down Expand Up @@ -723,7 +723,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a type is mismatched but TurnOffTypeChecking is used' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand Down Expand Up @@ -753,7 +753,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a value is mismatched but ExcludeProperties is used to exclude then' {
BeforeAll{
BeforeAll {
$desiredValues = @{
String = 'some other string'
Bool = $true
Expand Down Expand Up @@ -793,7 +793,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a value is mismatched but it is not in Properties then' {
BeforeAll{
BeforeAll {
$desiredValues = @{
String = 'some other string'
Bool = $true
Expand Down Expand Up @@ -862,7 +862,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When a value is mismatched but it is in Properties then' {
BeforeAll{
BeforeAll {
$properties = @(
'String'
'Bool'
Expand Down Expand Up @@ -934,7 +934,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When all values match' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand Down Expand Up @@ -1025,7 +1025,7 @@ Describe 'ComputerManagementDsc.Common\Compare-DscParameterState' {
}

Context 'When all values match' {
BeforeAll{
BeforeAll {
$desiredValues = [PSObject] @{
String = 'a string'
Bool = $true
Expand Down

0 comments on commit dafb626

Please sign in to comment.