DFSDsc: Updated LICENSE file to match the Microsoft Open Source Team standard. #80
Conversation
Git Pull from PowerShell/DFSDsc
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)
CHANGELOG.md, line 11 at r1 (raw file):
if opt-in. - Added .VSCode settings for applying DSC PSSA rules - fixes [Issue #75](https://github.com/PowerShell/DfsDsc/issues/75). - Updated LICENSE file to match the Microsoft Open Source Team standard.
Can you replace the full stop with a - and make the "Fixes" lower case 'f' (see the line above).
|
Thanks @PlagueHO I was wary of the 80 character limit on the AppVeyor tests from the other Repos. Have now updated. 👍 |
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
CHANGELOG.md, line 11 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you replace the full stop with a - and make the "Fixes" lower case 'f' (see the line above).
No worries. Updated and just pushed.
Codecov Report
@@ Coverage Diff @@
## dev #80 +/- ##
===================================
Coverage 95% 95%
===================================
Files 8 8
Lines 1064 1064
===================================
Hits 1014 1014
Misses 50 50 |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Hi @timhaintz - the test is failing because the new CHANGELOG.MD line is too long! 😢 |
|
Hehe, did you want -fixes on the next line or [Issues#] ? |
|
You can't begin a new line with - Updated LICENSE file to match the Microsoft Open Source Team
standard - fixes [Issue #79](https://github.com/PowerShell/DFSDsc/issues/79) |
|
Just pushed it slightly differently..... sorry..... |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)
CHANGELOG.md, line 12 at r4 (raw file):
- Added .VSCode settings for applying DSC PSSA rules - fixes [Issue #75](https://github.com/PowerShell/DfsDsc/issues/75). - Updated LICENSE file to match the Microsoft Open Source Team standard - fixes [Issue #79](https://github.com/PowerShell/DFSDsc/issues/79)
Almost there 😁 need to prepend the line with 2 spaces - otherwise MD thinks this is not part of the previous bullet.
|
THANK YOU! I thought I was all over markdown.... always learning. KAIZEN! Should be good now..... Thanks for your patience. |
There was a problem hiding this comment.
Awesome! Thanks @timhaintz! Love continuous learning 😁
Reviewed 1 of 1 files at r5.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
Pull Request (PR) description
In new repositories that are created by the Microsoft Open Source Team, the LICENSE file does not contain the year in the copyright "header".
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is