-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated tests to meet Pester V4 guidelines - Fixes #53 #56
Conversation
@johlju - I could have converted all the |
Codecov Report
@@ Coverage Diff @@
## dev #56 +/- ##
===================================
Coverage 96% 96%
===================================
Files 7 7
Lines 1020 1020
===================================
Hits 985 985
Misses 35 35 |
It’s okay by me if you want to do it. Will try to review the pending PRs tomorrow. |
Thanks @johlju - I did it to get it out of the way. Thanks again! |
Reviewed 2 of 16 files at r1, 14 of 14 files at r2. Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 221 at r2 (raw file):
These should be Comments from Reviewable |
Review status: 9 of 16 files reviewed at latest revision, 1 unresolved discussion. Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 221 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 7 of 7 files at r3. Comments from Reviewable |
Pull Request (PR) description
This PR updates the tests to meet Pester V4 guidelines.
This Pull Request (PR) fixes the following issues:
Task list:
@johlju - would you mind reviewing? I am hoping this is trivial as it is just a Pester V3 -> V4 conversion. But no rush at all. As always I'm eternally grateful for all your help on these resources (seriously, I don't know how I'd get changes through without you).
This change is