Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tests to meet Pester V4 guidelines - Fixes #53 #56

Merged
merged 4 commits into from
Jan 14, 2018
Merged

Updated tests to meet Pester V4 guidelines - Fixes #53 #56

merged 4 commits into from
Jan 14, 2018

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jan 13, 2018

Pull Request (PR) description
This PR updates the tests to meet Pester V4 guidelines.

This Pull Request (PR) fixes the following issues:

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

@johlju - would you mind reviewing? I am hoping this is trivial as it is just a Pester V3 -> V4 conversion. But no rush at all. As always I'm eternally grateful for all your help on these resources (seriously, I don't know how I'd get changes through without you).


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jan 13, 2018
@PlagueHO
Copy link
Member Author

@johlju - I could have converted all the It 'should to It 'Should (capital S for should) but there were so many that I didn't want to make the diff that large. Happy to do it though if you want (as it is just a simple search/replace).

@codecov-io
Copy link

codecov-io commented Jan 13, 2018

Codecov Report

Merging #56 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #56   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files         7      7           
  Lines      1020   1020           
===================================
  Hits        985    985           
  Misses       35     35

@johlju
Copy link
Member

johlju commented Jan 13, 2018

It’s okay by me if you want to do it. Will try to review the pending PRs tomorrow.

@PlagueHO
Copy link
Member Author

Thanks @johlju - I did it to get it out of the way. Thanks again!

@johlju
Copy link
Member

johlju commented Jan 14, 2018

Reviewed 2 of 16 files at r1, 14 of 14 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 221 at r2 (raw file):

-Exactly 1

These should be -Exactly -Times 1. Throughout.


Comments from Reviewable

@PlagueHO
Copy link
Member Author

Review status: 9 of 16 files reviewed at latest revision, 1 unresolved discussion.


Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 221 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

-Exactly 1

These should be -Exactly -Times 1. Throughout.

Done.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Jan 14, 2018

:lgtm:


Reviewed 7 of 7 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@PlagueHO PlagueHO merged commit 0803d6c into dsccommunity:dev Jan 14, 2018
@vors vors removed the needs review The pull request needs a code review. label Jan 14, 2018
@PlagueHO PlagueHO deleted the Issue-53 branch January 14, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Pester Test Syntax from v3 -> v4
4 participants