Prevent ResourceHelper and Common cmdlets from being exported - Fixes #33 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce kit modules. - Prevented ResourceHelper and Common module cmdlets from being exported to resolve conflicts with other resource modules.
PlagueHO
added
high priority
Codecov Report
@@ Coverage Diff @@
## dev #34 +/- ##
====================================
+ Coverage 96% 96% +<1%
====================================
Files 7 7
Lines 1013 1020 +7
====================================
+ Hits 978 985 +7
Misses 35 35 |
|
@PlagueHO Did you branch this from the issue-31 working branch? Looks like you got those changes in here as well (?). Could you rebase against dev? |
|
And the same comment as in xStorage |
|
Doh! @johlju - you're right - I did. It was getting really late and I didn't check the branch I was in when I created the new one. Fixed now. Also changed the "Should not throw" to "Should Not Throw" |
|
I figured ;) No worries :) |
|
Reviewed 9 of 10 files at r1, 1 of 1 files at r2. Comments from Reviewable |
|
Thanks @johlju ! |
vors
removed
high priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a high priority issue with newer versions of xNetworking, xCertificate, xStorage and xDFS conflicting with each other because the ResourceHelper cmdlets are being exported due to the way each resource imported them (using the PSD1 nested modules array).
This should be resolved in xNetworking, xStorage and xCertificate as well to ensure no other conflicts.
This also contains a new integration test that will check for any further conflicts between resource modules. At some point it might be possible to move this test into the DSCResource.Tests common tests to provide more comprehensive conflict prevention. However, because the conflicts will potentially be between three different modules the number of modules compared will have to go in over time.
This fixes #33
This change is