DFSReplicationGroup - update PrimaryMember to write-only but not test #138
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
===================================
Coverage 95% 96%
===================================
Files 8 8
Lines 1233 1252 +19
===================================
+ Hits 1183 1202 +19
Misses 50 50
|
|
Hey @PlagueHO - sorry, me again. Hope this is a quick one, let me know if you have any comments/suggestions :) Ta! |
|
Hi @Borgquite - sorry about t the delay. Been at a vibe come conference all week so will try and get into this over the weekend! |
|
No worries @PlagueHO - any free time you have much appreciated :) |
There was a problem hiding this comment.
Just minor style nit picks.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Borgquite)
CHANGELOG.md line 8 at r1 (raw file):
## [Unreleased] ### Fixed
Can you add a blank line after this one?
source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.psm1 line 537 at r1 (raw file):
) -join '' ) # See https://techcommunity.microsoft.com/t5/storage-at-microsoft/the-primary-member-in-dfs-replication/ba-p/423127
Could you change to a <# #> comment block?
source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.schema.mof line 16 at r1 (raw file):
[Write, Description("Specify if this content path should be read only.")] Boolean ReadOnly; [Write, Description("Specify if a member computer deletes files and folders immediately following inbound replication.")] Boolean RemoveDeletedFiles; [Write, Description("Used to configure this as the Primary Member. Every folder must have at least one primary member for initial replication to take place. Only set during initial creation of membership.")] Boolean PrimaryMember;
Can you change to single space before Only?
source/DSCResources/DSC_DFSReplicationGroupMembership/README.md line 7 at r1 (raw file):
Can you move NB to be on a new paragraph and use:
`
Note: ...
`
There was a problem hiding this comment.
No worries - all done :)
Reviewable status: 2 of 6 files reviewed, 4 unresolved discussions (waiting on @PlagueHO)
CHANGELOG.md line 8 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you add a blank line after this one?
Done.
source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.psm1 line 537 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Could you change to a <# #> comment block?
Done.
source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.schema.mof line 16 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you change to single space before
Only?
Done.
source/DSCResources/DSC_DFSReplicationGroupMembership/README.md line 7 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you move NB to be on a new paragraph and use:
`
Note: ...
`
Done.
There was a problem hiding this comment.
Sorry minor clarifications :D
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Borgquite)
source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.psm1 line 537 at r1 (raw file):
Previously, Borgquite (Chris Hill) wrote…
Done.
Apologies, I meant like this:
<#
See https://techcommunity.microsoft.com/t5/storage-at-microsoft/the-primary-member-in-dfs-replication/ba-p/423127
Do not flag as a change required as flag is cleared after initial sync
#>
source/DSCResources/DSC_DFSReplicationGroupMembership/README.md line 7 at r1 (raw file):
Ah, I see Reviewable helpfully converted by example to MD.
Can you prepend:
> Note: The PrimaryMember flag is automatically cleared by DFS once an initial
> replication sync takes place, so is not tested by this resource.
This will make the MD format it.
There was a problem hiding this comment.
No worries - all OK now?
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @PlagueHO)
source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.psm1 line 537 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Apologies, I meant like this:
<#
See https://techcommunity.microsoft.com/t5/storage-at-microsoft/the-primary-member-in-dfs-replication/ba-p/423127
Do not flag as a change required as flag is cleared after initial sync
#>
Done.
source/DSCResources/DSC_DFSReplicationGroupMembership/README.md line 7 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Ah, I see Reviewable helpfully converted by example to MD.
Can you prepend:
> Note: The PrimaryMember flag is automatically cleared by DFS once an initial > replication sync takes place, so is not tested by this resource.This will make the MD format it.
Done.
There was a problem hiding this comment.
Thanks @Borgquite !
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Borgquite)
|
@microsoft-github-policy-service agree company="Mission Aviation Fellowship International" |
Pull Request (PR) description
Make PrimaryMember a write-only property that should not test
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is