Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Pester, Convert to DSCResource.Common - Fixes #102, #103 and #105 #106

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Sep 11, 2020

Pull Request (PR) description

  • Updated to use the common module DscResource.Common - Fixes Issue #102.
  • Fixed build failures caused by changes in ModuleBuilder module v1.7.0
    by changing CopyDirectories to CopyPaths - Fixes Issue #103.
  • Pin Pester module to 4.10.1 because Pester 5.0 is missing code
    coverage - Fixes Issue #105.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you have a chance?


This change is Reviewable

@PlagueHO
Copy link
Member Author

Hi @johlju - would you mind reviewing when you have time?

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Sep 18, 2020
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Sep 20, 2020
@PlagueHO PlagueHO merged commit 9475909 into dsccommunity:master Sep 21, 2020
@PlagueHO PlagueHO deleted the PlagueHO/issue105 branch September 21, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
2 participants